Repository navigation
feat: Add BundleURL, initiator to Attestation - #4647
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4647 +/- ##
========================================
Coverage 98.61% 98.62%
========================================
Files 199 201 +2
Lines 18689 18811 +122
========================================
+ Hits 18431 18553 +122
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Frank2006x!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Not-Dhananjay-Mishra
left a comment
Not-Dhananjay-Mishra
left a comment
There was a problem hiding this comment.
Just one nit. Otherwise, LGTM 🚀
| // The provided bundle can be used to verify the provenance of artifacts. | ||
| // | ||
| // https://docs.github.com/en/actions/security-for-github-actions/using-artifact-attestations/using-artifact-attestations-to-establish-provenance-for-builds | ||
| type Attestation struct { |
There was a problem hiding this comment.
initiator field is also missing from the Attestation struct, Can you add that as well?
"bundle_url": {
"type": "string"
},
"initiator": {
"type": "string"
}There was a problem hiding this comment.
@Not-Dhananjay-Mishra @gmlewis included initiator field as well . kindly give a check
There was a problem hiding this comment.
@Frank2006x Could you please update the title and description as well?
|
Added the initiator into the Attestation struct as requested |
Frank2006x
changed the title
gmlewis
changed the title
|
Thank you, @Frank2006x and @Not-Dhananjay-Mishra! |
Summary
Adds
BundleURL , initiator *stringtoAttestationand addsomitemptytoBundle. The GitHub REST API for artifact attestations now providesbundle_urlto download the Sigstore bundle instead of returning the bundle inline.This addresses the Attestations: Remove the bundle property from attestation list responses (users should use bundle_url instead). #4077 (comment).
part of #4077
Tests
go test ./github script/test.sh script/lint.shAssisted Contribution
Drafted with the assistance of an AI coding agent. All changes and test results were reviewed and verified against repository
guidelines.